1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/syncterm/bbslist.c

    From Deucе@VERT to Git commit to main/sbbs/master on Sunday, December 07, 2025 01:48:31
    https://gitlab.synchro.net/main/sbbs/-/commit/fb3fdc7130309a73ff97a374
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Wait up to a second for a keypress in BBS list.

    We already have nowait to force updates, so this is fine.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thursday, December 18, 2025 12:50:55
    https://gitlab.synchro.net/main/sbbs/-/commit/eb95d5cef735de079e8b34a7
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Fix signed comparisons in intbufcmp()

    Makes negative values sort correctly. Noticable with the new
    explicit sort order feature.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thursday, December 18, 2025 12:59:01
    https://gitlab.synchro.net/main/sbbs/-/commit/3362dfaa1ea2fd610fa60763
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Re-sort list after changing explicit sort order

    The change wasn't being detected as a change to the list, so items
    were not re-sorted until something else changed or the list was
    re-loaded for other reasons.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tuesday, December 30, 2025 17:15:23
    https://gitlab.synchro.net/main/sbbs/-/commit/20962b53d4e3492c98eee0d9
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Fix potential file stream leak

    When changing the number of key derivation iterations but the list
    is not currently encrypted, the list file would never be closed.

    Likely not the cause of the recent default settings issue on Windows.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wednesday, December 31, 2025 20:37:36
    https://gitlab.synchro.net/main/sbbs/-/commit/eef0551b0c98c7fb1bdc64c5
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Don't pass the defaults pointer when we don't want to read them

    ie: Don't read default connection settings from system list or
    the web lists.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, February 22, 2026 09:41:31
    https://gitlab.synchro.net/main/sbbs/-/commit/37040a2302385f7970938906
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Don't use strnicmp() with length of zero because Win32 is stupid.

    May fix tickets 224, 220, and 217.
    I need to boot Windows somewhere and test.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Monday, February 23, 2026 11:23:15
    https://gitlab.synchro.net/main/sbbs/-/commit/19d9da43ee78d3fe989c8e6f
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Fix Custom Screen Mode Program Setting

    Was not shown in menu.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, March 15, 2026 01:06:05
    https://gitlab.synchro.net/main/sbbs/-/commit/75cc9b15e717d6cf77dc90b0
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Fix stack buffer overflows in bbslist.c build_edit_list()

    The opt[][69] array has 69-byte elements, but several sprintf() calls
    could write past that:

    - "Address %s" with item->addr (LIST_ADDR_MAX=64, +18 = 83)
    - "Phone Number %s", "Device Name %s", etc. (same field)
    - "GHost Program %s" with item->password (MAX_PASSWD_LEN=128, +18 = 147)
    - "BBS Username %s" with item->password (same)
    - "Font %s" with item->font (80 bytes, +18 = 98)

    Changed these to snprintf(opt[i++], sizeof(opt[0]), ...) to truncate
    instead of overflowing. Other sprintf() calls in the same function
    already used printf_trunc() or format short bounded values (Yes/No,
    small ints, "********") and are not affected.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, March 15, 2026 01:06:05
    https://gitlab.synchro.net/main/sbbs/-/commit/d89bbbce2b372e8259d40fbc
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Clamp ANSIMusic value read from BBS list files

    entry->music was read with iniGetInteger() and used unchecked as an
    index into music_names[] (a 3-element array) in build_edit_list().
    A malicious web-hosted syncterm.lst could set ANSIMusic=999 and
    cause an out-of-bounds read, likely crashing when sprintf() tries
    to dereference the wild pointer.

    Clamp to the valid range [CTERM_MUSIC_SYNCTERM..CTERM_MUSIC_ENABLED]
    after reading, defaulting back to CTERM_MUSIC_BANSI on bad values.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, March 15, 2026 14:09:13
    https://gitlab.synchro.net/main/sbbs/-/commit/3c40ff95eaad51693eb4f60a
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Fix multiple bugs in bbslist.c

    - Add NULL check after malloc in BBS list entry creation, undoing the
    list manipulation on failure.
    - printf_trunc: guard against size_t underflow when remain_len < 5
    by falling back to "..." instead of indexing with a wrapped value.
    - Fix strlcpy using sizeof(tmpn) instead of sizeof(tmpv) for the
    destination buffer (harmless since both are same size, but wrong).
    - Fix memory leak: asprintf allocations for File Locations and Build
    Options showbuf dialogs were never freed. Add free(p) after each
    showbuf call, guarded by NULL check on p.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Saturday, March 21, 2026 17:44:35
    https://gitlab.synchro.net/main/sbbs/-/commit/153ec64873f7fe654a0c73c7
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Fix ticket 231

    Menu was being redrawn for no reason.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Saturday, March 21, 2026 20:46:07
    https://gitlab.synchro.net/main/sbbs/-/commit/7a9b5cfe88159244e8b00139
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Put explicit sort order first in the default sort orders.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Saturday, March 21, 2026 21:19:25
    https://gitlab.synchro.net/main/sbbs/-/commit/8c8e6adfe91282cb21824903
    Modified Files:
    src/syncterm/bbslist.c
    Log Message:
    Wow, fix the things where things were wrong.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net